Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikvclient: fix a bug that double close channels. (#10991) #11101

Merged
merged 4 commits into from
Jul 9, 2019
Merged

tikvclient: fix a bug that double close channels. (#10991) #11101

merged 4 commits into from
Jul 9, 2019

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jul 5, 2019 •
edited
Loading

cherry pick #10991

@hicqu hicqu requested a review from tiancaiamao July 5, 2019 11:04
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2019
lysu
lysu approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Jul 5, 2019

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Jul 7, 2019

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Jul 7, 2019

@hicqu Please fix ci

@hicqu
Copy link
Contributor Author

hicqu commented Jul 8, 2019

For the mysql test it's not caused by this commit. Seems @zz-jason is fixing it?

@winkyao winkyao added priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0 cherry-pick labels Jul 8, 2019
@zz-jason
Copy link
Member

zz-jason commented Jul 8, 2019

/run-integration-common-test
/run-common-test
/run-unit-test

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2019
@crazycs520
Copy link
Contributor

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Jul 9, 2019

/run-unit-test

@zz-jason zz-jason merged commit 73c34e1 into pingcap:release-3.0 Jul 9, 2019
@jackysp jackysp mentioned this pull request Jul 10, 2019
Closed
@hicqu hicqu deleted the release-3.0 branch July 10, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hicqu @tiancaiamao @lysu @winkyao @zz-jason @crazycs520