planner: make WindowFunction uncacheable in prepare #11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11035 +/- ##
===============================================
- Coverage 81.1212% 81.066% -0.0552%
===============================================
Files 419 419
Lines 90350 89580 -770
===============================================
- Hits 73293 72619 -674
+ Misses 11785 11731 -54
+ Partials 5272 5230 -42 |
|
/run-all-tests tidb-test=pr/759 |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Jul 3, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
FrameBoundis pre-calculated when building logical plan. So it will cause error if we cache it.But it's safe to evaluate it later in execution phase. We'll make it cacheable in the future.
Check List
Tests
Related changes