Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix the issue that pb memory cannot be released quickly (#10815) #10833

Merged
merged 3 commits into from
Jun 19, 2019
Merged

executor: fix the issue that pb memory cannot be released quickly (#10815) #10833

merged 3 commits into from
Jun 19, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 18, 2019

cherry-pick for #10815.

@qw4990 qw4990 added priority/P1 The issue has P1 priority. type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Jun 18, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested review from zz-jason and XuHuaiyu June 18, 2019 08:19
XuHuaiyu
XuHuaiyu reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jun 18, 2019
zz-jason
zz-jason approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit f185720 into pingcap:release-2.1 Jun 19, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
priority/P1 The issue has P1 priority. priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @zz-jason @XuHuaiyu