Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: support dump/load correlation of histogram #10573

Merged
merged 3 commits into from
May 23, 2019

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Stats dumped using HTTP API does not contain order correlation of columns.

What is changed and how it works?

Add dump/load support for correlation of histogram.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Breaking backward compatibility: stats dumped from old versions can be successfully loaded into current version, while stats dumped from current version cannot be loaded into old versions;

Related changes

  • Need to update the documentation

@eurekaka eurekaka added component/statistics component/server type/enhancement The issue or PR belongs to an enhancement. labels May 22, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-integration-ddl-test

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #10573 into master will increase coverage by 0.003%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master     #10573       +/-   ##
===============================================
+ Coverage   77.3275%   77.3306%   +0.003%     
===============================================
  Files           413        413               
  Lines         87322      87378       +56     
===============================================
+ Hits          67524      67570       +46     
- Misses        14605      14606        +1     
- Partials       5193       5202        +9

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label May 23, 2019
@zz-jason zz-jason merged commit 183648f into pingcap:master May 23, 2019
@eurekaka eurekaka deleted the dump_correlation branch May 23, 2019 06:17
db-storage pushed a commit to db-storage/tidb that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server component/statistics status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants