Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Stop server startup if an unrecognized option is found in a config file (#9855) #10096

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Apr 10, 2019

What problem does this PR solve?

Cherry pick from #9855.


This change is Reviewable

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@xiekeyi98 xiekeyi98 changed the title [WIP]config: Stop server startup if an unrecognized option is found in a config file (#9855) config: Stop server startup if an unrecognized option is found in a config file (#9855) Apr 10, 2019
@xiekeyi98
Copy link
Contributor Author

/run-unit-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiekeyi98 xiekeyi98 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiekeyi98 xiekeyi98 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2019
@ngaut ngaut merged commit 276699f into pingcap:release-2.1 Apr 10, 2019
@xiekeyi98 xiekeyi98 deleted the release-2.1 branch April 10, 2019 09:32
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants