Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: refactor test wait for checkpoint to advance #57609

Closed
Tristan1900 opened this issue Nov 21, 2024 · 0 comments · Fixed by #57612
Closed

br: refactor test wait for checkpoint to advance #57609

Tristan1900 opened this issue Nov 21, 2024 · 0 comments · Fixed by #57612
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Tristan1900
Copy link
Contributor

Enhancement

currently every test is copying the same code block which is not tedious and unreadable, we can just make it a method
@Tristan1900 Tristan1900 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 21, 2024
@Tristan1900 Tristan1900 mentioned this issue Nov 21, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2024
@Tristan1900
br: refactor test to use wait checkpoint method (#57612)
9cc4a20 
close #57609
@ti-chi-bot ti-chi-bot mentioned this issue Dec 24, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Dec 24, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 24, 2024
@ti-chi-bot
br: refactor test to use wait checkpoint method (#57612) (#58498)
9a5b05a 
close #57609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: refactor test to use wait checkpoint method Tristan1900/tidb
1 participant
@Tristan1900