Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add index job rollback after inject one of tidb failure for 1mins or tidb rolling restart #47122

Closed
Lily2025 opened this issue Sep 20, 2023 · 5 comments
Assignees
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major type/bug The issue is confirmed as a bug.

Comments

@Lily2025
Copy link

Lily2025 commented Sep 20, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

test-plan id : 2730169
1、tidb_enable_dist_task='on'
2、add index
3、inject one of tidb failure last for 1mins

[2023/09/19 19:15:21.708 +08:00] [INFO] [util.go:73] ["alter table sbtest1 add index index_test_1695122121693 (c)"]
[2023/09/19 19:15:50.842 +08:00] [INFO] [chaos.go:203] ["fault will last for"] [duration=1m0s]
[2023/09/19 19:15:50.842 +08:00] [INFO] [chaos.go:64] ["Run chaos"] [name=failure] [selectors="[endless-ha-test-add-index-tps-2730169-1-569/tc-tidb-0,endless-ha-test-add-index-tps-2730169-1-569/tc-tidb-1]"] [selectorsRetainPolicy(selectors)="[endless-ha-test-add-index-tps-2730169-1-569/tc-tidb-1]"] [targetSelectors="[nil]"] [targetSelectorsRetainPolicy(targetSelectors)="[nil]"] [experimentSpec="FailureExperimentSpec{Duration: "", Scheduler: }"]

2. What did you expect to see? (Required)

add index can succeed.

3. What did you see instead (Required)

add index job rollback after inject one of tidb failure for 1mins

[2023/09/19 19:16:21.710 +08:00] [INFO] [db.go:103] ["select job_id, job_type, state from information_schema.ddl_jobs where query = 'alter table sbtest1 add index index_test_1695122121693 (c)'"]
[2023/09/19 19:16:21.746 +08:00] [INFO] [add_index.go:312] ["jobId: 422, job type: add index /* ingest */, state: rollback done"]

4. What is your TiDB version? (Required)

./tidb-server -V
Release Version: v7.4.0-alpha
Edition: Community
Git Commit Hash: 4cc6c65
Git Branch: heads/refs/tags/v7.4.0-alpha
UTC Build Time: 2023-09-18 11:45:50
GoVersion: go1.21.1
Race Enabled: false
Check Table Before Drop: false
Store: unistore
2023-09-19T15:58:55.622+0800

@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label Sep 20, 2023
@Lily2025
Copy link
Author

/assign ywqzzy

@jebter
Copy link

jebter commented Sep 21, 2023

/component ddl
/severity major

@ti-chi-bot ti-chi-bot bot added component/ddl This issue is related to DDL of TiDB. severity/major may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 21, 2023
@Lily2025 Lily2025 changed the title add index job rollback after inject one of tidb failure for 1mins add index job rollback after inject one of tidb failure for 1mins or tidb rolling restart Sep 25, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Oct 30, 2023

/close

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

@ywqzzy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot closed this as completed Oct 30, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Nov 15, 2023

close as #47313 fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants