Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in v6.5.4, lightning failed at checksum stage when PD leader change #46540

Closed
lance6716 opened this issue Aug 31, 2023 · 2 comments
Closed

in v6.5.4, lightning failed at checksum stage when PD leader change #46540

lance6716 opened this issue Aug 31, 2023 · 2 comments
Assignees
Labels
affects-6.5 component/lightning This issue is related to Lightning of TiDB. type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

lance6716 commented Aug 31, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

EOF
github.com/tikv/pd/client.(*client).processTSORequests
	/go/pkg/mod/github.com/tikv/pd/client@v0.0.0-20221031025758-80f0d8ca4d07/client.go:1090
github.com/tikv/pd/client.(*client).handleDispatcher
	/go/pkg/mod/github.com/tikv/pd/client@v0.0.0-20221031025758-80f0d8ca4d07/client.go:847
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1594
github.com/tikv/pd/client.(*tsoRequest).Wait
	/go/pkg/mod/github.com/tikv/pd/client@v0.0.0-20221031025758-80f0d8ca4d07/client.go:1313
github.com/tikv/pd/client.(*client).GetTS
	/go/pkg/mod/github.com/tikv/pd/client@v0.0.0-20221031025758-80f0d8ca4d07/client.go:1333
github.com/pingcap/tidb/br/pkg/lightning/restore.(*tikvChecksumManager).Checksum
	/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/br/br/pkg/lightning/restore/checksum.go:315
github.com/pingcap/tidb/br/pkg/lightning/restore.DoChecksum
	/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/br/br/pkg/lightning/restore/checksum.go:161
github.com/pingcap/tidb/br/pkg/lightning/restore.(*TableRestore).postProcess
	/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/br/br/pkg/lightning/restore/table_restore.go:860
github.com/pingcap/tidb/br/pkg/lightning/restore.(*Controller).restoreTables.func7.1
	/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/br/br/pkg/lightning/restore/restore.go:1682
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1594
fetch tso from pd failed

4. What is your TiDB version? (Required)

@lance6716 lance6716 added the type/bug The issue is confirmed as a bug. label Aug 31, 2023
@lance6716
Copy link
Contributor Author

lance6716 commented Aug 31, 2023

lightning can reuse pd.IsLeaderChange to retry when PD side ports ErrClientTSOStreamClosed into release-6.5 which introduced in https://github.com/tikv/pd/pull/6160/files

@lance6716
Copy link
Contributor Author

image

@tiancaiamao tiancaiamao added the component/lightning This issue is related to Lightning of TiDB. label Aug 31, 2023
ti-chi-bot bot pushed a commit to tikv/pd that referenced this issue Sep 4, 2023
ref pingcap/tidb#46540

Signed-off-by: lance6716 <lance6716@gmail.com>
@jayl1e jayl1e mentioned this issue Sep 21, 2023
11 tasks
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 component/lightning This issue is related to Lightning of TiDB. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants