Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the Request.TxnScope is missing in distsql #43365

Closed
you06 opened this issue Apr 24, 2023 · 1 comment · Fixed by #43367
Closed

the Request.TxnScope is missing in distsql #43365

you06 opened this issue Apr 24, 2023 · 1 comment · Fixed by #43367
Labels
affects-6.5 affects-7.1 severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@you06
Copy link
Contributor

you06 commented Apr 24, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run stale-read with large txn, it reports "region data not ready".

From the log

[2023/04/24 16:25:22.886 +08:00] [INFO] [coprocessor.go:1264] ["[TIME_COP_PROCESS] resp_time:6.002145677s txnStartTS:441011326093099008 region_id:17657 store_addr:192.168.80.4:23160 backoff_ms:18108 backoff_types:[dataNotReady,dataNotReady,dataNotReady,regionMiss,dataNotReady,dataNotReady,dataNotReady,regionMiss,dataNotReady,dataNotReady,dataNotReady,regionMiss,dataNotReady,dataNotReady,dataNotReady,regionMiss,dataNotReady,dataNotReady,dataNotReady,regionMiss,dataNotReady,dataNotReady,dataNotReady]"] [conn=2965838057925773075]

2. What did you expect to see? (Required)

No slow log caused by dataNotReady after we use snapshot read directly once meeting data is not ready.

3. What did you see instead (Required)

The query failed by "region data not ready".

4. What is your TiDB version? (Required)

nightly
@you06 you06 added type/bug The issue is confirmed as a bug. severity/major labels Apr 24, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Apr 24, 2023
@you06 you06 removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Apr 24, 2023
@you06 you06 mentioned this issue Apr 24, 2023
Merged
12 tasks
@you06
Copy link
Contributor Author

you06 commented Apr 24, 2023

There is no global stale read optimization before 7.1, so this only affect master and 7.1.

ti-chi-bot bot pushed a commit that referenced this issue Apr 24, 2023
@you06
store/copr: fix missting Request.TxnScope (#43367)
6a3721a 
close #43365
@ti-chi-bot ti-chi-bot mentioned this issue Apr 24, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 25, 2023
@ti-chi-bot
store/copr: fix missting Request.TxnScope (#43367) (#43374)
a864476 
close #43365
@cfzjywxk cfzjywxk mentioned this issue Apr 28, 2023
Closed
@ti-chi-bot ti-chi-bot mentioned this issue May 5, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 21, 2023
@ti-chi-bot
store/copr: fix missting Request.TxnScope (#43367) (#43553)
443f5ce 
close #43365
@cfzjywxk cfzjywxk mentioned this issue Jun 21, 2023
Merged
16 tasks
@jebter jebter added the sig/transaction SIG:Transaction label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store/copr: fix missting Request.TxnScope you06/tidb
2 participants
@jebter @you06