Potential overflow when store ActionTypes
in schemaDiff
#39656
Labels
type/enhancement
The issue or PR belongs to an enhancement.
ActionTypes
in schemaDiff
#39656
Enhancement
tidb/domain/domain.go
Lines 345 to 355 in 1ddc592
See the code above, we used
int64(1<<diff.Type)
to store the ddl type before, but this will overflow when the ddl type is greater than 64 (now the biggest one is 67). IMO, we could store the type directly instead of left shift it.The text was updated successfully, but these errors were encountered: