Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turning on tidb_restricted_read_only doesn't affects super_read_only #31745

Closed
ichn-hu opened this issue Jan 17, 2022 · 1 comment · Fixed by #31746
Closed

turning on tidb_restricted_read_only doesn't affects super_read_only #31745

ichn-hu opened this issue Jan 17, 2022 · 1 comment · Fixed by #31746
Assignees
@ichn-hu
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@ichn-hu
Copy link
Contributor

ichn-hu commented Jan 17, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

when turning on tidb_restricted_read_only it is also meant to turn on tidb_super_read_only, and when tidb_restricted_read_only is on, the user can't turn off tidb_super_read_only.

2. What did you expect to see? (Required)

as described

3. What did you see instead (Required)

the constraints are not enforced

4. What is your TiDB version? (Required)

master
@ichn-hu ichn-hu added the type/bug The issue is confirmed as a bug. label Jan 17, 2022
@ichn-hu ichn-hu self-assigned this Jan 17, 2022
@ichn-hu ichn-hu mentioned this issue Jan 17, 2022
Merged
12 tasks
@ichn-hu ichn-hu added affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. severity/major labels Jan 20, 2022
ti-chi-bot pushed a commit that referenced this issue Jan 20, 2022
@ichn-hu
variables: add constraints on tidb_super_read_only when tidb_restrict…
1a146fa 
…ed_read_only is turned on (#31746)

close #31745
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

This was referenced Jan 20, 2022
Closed
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Feb 17, 2022
@ti-srebot
variables: add constraints on tidb_super_read_only when tidb_restrict…
b0d865c 
…ed_read_only is turned on (#31746) (#31842)

close #31745
ti-chi-bot pushed a commit that referenced this issue Feb 22, 2022
@ti-srebot
variables: add constraints on tidb_super_read_only when tidb_restrict…
ac9c004 
…ed_read_only is turned on (#31746) (#31841)

close #31745
@guo-shaoge guo-shaoge mentioned this issue Feb 25, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichn-hu ichn-hu

Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
3 participants
@jebter @aytrack @ichn-hu