Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics for small cached table #29958

Closed
Tracked by #25293
tiancaiamao opened this issue Nov 21, 2021 · 3 comments · Fixed by #32171
Closed
Tracked by #25293

metrics for small cached table #29958

tiancaiamao opened this issue Nov 21, 2021 · 3 comments · Fixed by #32171
Assignees
@tiancaiamao
Labels
feature/developing the related feature is in development type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

No description provided.

@tiancaiamao tiancaiamao mentioned this issue Nov 21, 2021
Closed
32 tasks
@sylzd
Copy link
Contributor

sylzd commented Nov 23, 2021

what metrics should we add?

@tiancaiamao
Copy link
Contributor Author

For example, the read / write QPS on cached table; any error happens;
renew lease operation;
anything that is useful for us to debug the real online service...

@JayLZhou
Copy link
Contributor

/assign

@tiancaiamao tiancaiamao mentioned this issue Feb 8, 2022
Merged
12 tasks
@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. feature/developing the related feature is in development labels Feb 8, 2022
@tiancaiamao tiancaiamao assigned tiancaiamao and unassigned JayLZhou Feb 8, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 11, 2022
@tiancaiamao
metrics,executor: add metrics for reading from table cache (#32171)
d8fd06d 
close #29958
tiancaiamao added a commit to tiancaiamao/tidb that referenced this issue Feb 21, 2022
@tiancaiamao
metrics,executor: add metrics for reading from table cache (pingcap#3…
bccb811 
…2171)

close pingcap#29958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
feature/developing the related feature is in development type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics,executor: add metrics for reading from table cache tiancaiamao/tidb
3 participants
@tiancaiamao @sylzd @JayLZhou