Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate test-infra to testify for br/pkg/lightning/backend #28234

Closed
6 tasks done
Tracked by #28170
tisonkun opened this issue Sep 22, 2021 · 8 comments
Closed
6 tasks done
Tracked by #28170

migrate test-infra to testify for br/pkg/lightning/backend #28234

tisonkun opened this issue Sep 22, 2021 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 22, 2021
@ArberSephirotheca
Copy link
Contributor

/assign

@sleepymole
Copy link
Contributor

Hi @ArberSephirotheca, I'm working for restructuring the code under br/pkg/lightning/backend/local. Meanwhile, the test will be restructured too. I'm not sure if you have already had some work done on this. If you haven't started yet, how about split this task into multiple sub tasks? Since there is much code under br/pkg/lightning/backend🤣.

@ArberSephirotheca
Copy link
Contributor

@gozssky Sure, I was looking at the code this week and haven't started the migration. It is indeed a lot of code, so It would be great if I can begin with smaller part.

@sleepymole
Copy link
Contributor

@tisonkun As discussed above, could you please help to divide this task into multiple subtasks?

@tisonkun
Copy link
Contributor Author

@gozssky @ArberSephirotheca created. Feel free to take subtasks.

@ArberSephirotheca
Copy link
Contributor

/unassign

@sleepymole
Copy link
Contributor

/close

@ti-chi-bot
Copy link
Member

@gozssky: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants