expression: implement vectorized evaluation for builtinIntIsNullSig (…

…#12520)
pingcap · Oct 8, 2019 · fd51034 · fd51034
1 parent 5e2f388
commit fd51034
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/expression/builtin_op_vec.go b/expression/builtin_op_vec.go
@@ -141,11 +141,24 @@ func (b *builtinUnaryMinusDecimalSig) vecEvalDecimal(input *chunk.Chunk, result
 }
 
 func (b *builtinIntIsNullSig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinIntIsNullSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	if err := b.args[0].VecEvalInt(b.ctx, input, result); err != nil {
+		return err
+	}
+
+	i64s := result.Int64s()
+	for i := 0; i < len(i64s); i++ {
+		if result.IsNull(i) {
+			i64s[i] = 1
+			result.SetNull(i, false)
+		} else {
+			i64s[i] = 0
+		}
+	}
+	return nil
 }
 
 func (b *builtinRealIsNullSig) vectorized() bool {

diff --git a/expression/builtin_op_vec_test.go b/expression/builtin_op_vec_test.go
@@ -46,6 +46,7 @@ var vecBuiltinOpCases = map[string][]vecExprBenchCase{
 	},
 	ast.UnaryMinus: {},
 	ast.IsNull: {
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt}},
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDecimal}},
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDuration}},
 	},