Skip to content

Commit

Permalink
load data: skip physical mode test (#43959) (#43961)
Browse files Browse the repository at this point in the history
ref #42930
  • Loading branch information
ti-chi-bot authored May 18, 2023
1 parent 9ee4937 commit acf23d4
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 10 deletions.
1 change: 1 addition & 0 deletions tests/realtikvtest/loaddatatest/detach_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ var detachedCases = []detachedCase{
}

func (s *mockGCSSuite) TestSameBehaviourDetachedOrNot() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.testSameBehaviourDetachedOrNot(importer.LogicalImportMode)
s.testSameBehaviourDetachedOrNot(importer.PhysicalImportMode)
}
Expand Down
18 changes: 13 additions & 5 deletions tests/realtikvtest/loaddatatest/load_data_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func (s *mockGCSSuite) prepareAndUseDB(db string) {
}

func (s *mockGCSSuite) TestPhysicalMode() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -144,6 +145,7 @@ func (s *mockGCSSuite) TestPhysicalMode() {
}

func (s *mockGCSSuite) TestInputNull() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand All @@ -169,6 +171,7 @@ func (s *mockGCSSuite) TestInputNull() {
}

func (s *mockGCSSuite) TestIgnoreNLines() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{BucketName: "test-multi-load", Name: "skip-rows-1.csv"},
Content: []byte(`1,test1,11
Expand Down Expand Up @@ -222,6 +225,7 @@ func (s *mockGCSSuite) TestIgnoreNLines() {
}

func (s *mockGCSSuite) TestGeneratedCol() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand All @@ -243,6 +247,7 @@ func (s *mockGCSSuite) TestGeneratedCol() {
}

func (s *mockGCSSuite) TestInputCountMisMatchAndDefault() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -277,6 +282,7 @@ func (s *mockGCSSuite) TestInputCountMisMatchAndDefault() {
}

func (s *mockGCSSuite) TestDeliverBytesRows() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -321,7 +327,7 @@ func (s *mockGCSSuite) TestDeliverBytesRows() {

func (s *mockGCSSuite) TestMultiValueIndex() {
s.testMultiValueIndex(importer.LogicalImportMode)
s.testMultiValueIndex(importer.PhysicalImportMode)
//s.testMultiValueIndex(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testMultiValueIndex(importMode string) {
Expand Down Expand Up @@ -355,7 +361,7 @@ func (s *mockGCSSuite) testMultiValueIndex(importMode string) {

func (s *mockGCSSuite) TestMixedCompression() {
s.testMixedCompression(importer.LogicalImportMode)
s.testMixedCompression(importer.PhysicalImportMode)
//s.testMixedCompression(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testMixedCompression(importMode string) {
Expand Down Expand Up @@ -415,7 +421,7 @@ func (s *mockGCSSuite) testMixedCompression(importMode string) {

func (s *mockGCSSuite) TestLoadSQLDump() {
s.testLoadSQLDump(importer.LogicalImportMode)
s.testLoadSQLDump(importer.PhysicalImportMode)
//s.testLoadSQLDump(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testLoadSQLDump(importMode string) {
Expand Down Expand Up @@ -453,7 +459,7 @@ func (s *mockGCSSuite) testLoadSQLDump(importMode string) {

func (s *mockGCSSuite) TestGBK() {
s.testGBK(importer.LogicalImportMode)
s.testGBK(importer.PhysicalImportMode)
//s.testGBK(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testGBK(importMode string) {
Expand Down Expand Up @@ -563,7 +569,7 @@ func (s *mockGCSSuite) testGBK(importMode string) {

func (s *mockGCSSuite) TestOtherCharset() {
s.testOtherCharset(importer.LogicalImportMode)
s.testOtherCharset(importer.PhysicalImportMode)
//s.testOtherCharset(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testOtherCharset(importMode string) {
Expand Down Expand Up @@ -656,6 +662,7 @@ func (s *mockGCSSuite) testOtherCharset(importMode string) {
}

func (s *mockGCSSuite) TestMaxWriteSpeed() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.tk.MustExec("DROP DATABASE IF EXISTS load_test_write_speed;")
s.tk.MustExec("CREATE DATABASE load_test_write_speed;")
s.tk.MustExec(`CREATE TABLE load_test_write_speed.t(a int, b int)`)
Expand Down Expand Up @@ -698,6 +705,7 @@ func (s *mockGCSSuite) TestMaxWriteSpeed() {
}

func (s *mockGCSSuite) TestChecksumNotMatch() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down
2 changes: 1 addition & 1 deletion tests/realtikvtest/loaddatatest/one_parquet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var content []byte

func (s *mockGCSSuite) TestLoadParquet() {
s.testLoadParquet(importer.LogicalImportMode)
s.testLoadParquet(importer.PhysicalImportMode)
//s.testLoadParquet(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testLoadParquet(importMode string) {
Expand Down
2 changes: 1 addition & 1 deletion tests/realtikvtest/loaddatatest/operate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

func (s *mockGCSSuite) TestOperateRunningJob() {
s.testOperateRunningJob(importer.LogicalImportMode)
s.testOperateRunningJob(importer.PhysicalImportMode)
//s.testOperateRunningJob(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testOperateRunningJob(importMode string) {
Expand Down
1 change: 1 addition & 0 deletions tests/realtikvtest/loaddatatest/precheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
)

func (s *mockGCSSuite) TestPreCheckTableNotEmpty() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "precheck-tbl-empty",
Expand Down
5 changes: 2 additions & 3 deletions tests/realtikvtest/loaddatatest/show_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ func (s *mockGCSSuite) simpleShowLoadDataJobs(importMode string) {
}

func (s *mockGCSSuite) TestSimpleShowLoadDataJobs() {
s.simpleShowLoadDataJobs(importer.PhysicalImportMode)

//s.simpleShowLoadDataJobs(importer.PhysicalImportMode)
s.simpleShowLoadDataJobs(importer.LogicalImportMode)

user := &auth.UserIdentity{
Expand Down Expand Up @@ -221,7 +220,7 @@ func (s *mockGCSSuite) TestSimpleShowLoadDataJobs() {

func (s *mockGCSSuite) TestInternalStatus() {
s.testInternalStatus(importer.LogicalImportMode)
s.testInternalStatus(importer.PhysicalImportMode)
//s.testInternalStatus(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testInternalStatus(importMode string) {
Expand Down

0 comments on commit acf23d4

Please sign in to comment.