Skip to content

Commit

Permalink
server: fix review comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
lysu committed Jun 28, 2018
1 parent 0547af6 commit 91bccdf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions server/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -898,11 +898,10 @@ func (cc *clientConn) handleFieldList(sql string) (err error) {
return errors.Trace(err)
}
data := make([]byte, 4, 1024)
for _, v := range columns {
for _, column := range columns {
// Current we doesn't output defaultValue but reserve defaultValue length byte to make mariadb client happy.
// https://dev.mysql.com/doc/internals/en/com-query-response.html#column-definition
// TODO: fill the right DefaultValues.
column := v
column.DefaultValueLength = 0
column.DefaultValue = []byte{}

Expand Down

0 comments on commit 91bccdf

Please sign in to comment.