return the first error

pingcap · Dec 13, 2022 · 8aa0c7f · 8aa0c7f
1 parent 5050ebf
commit 8aa0c7f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/ddl/ingest/engine.go b/ddl/ingest/engine.go
@@ -193,14 +193,19 @@ func (ei *engineInfo) newWriterContext(workerID int) (*WriterContext, error) {
 }
 
 func (ei *engineInfo) closeWriters() error {
-	var err error
+	var firstErr error
 	for wid := range ei.writerCache.Keys() {
 		if w, ok := ei.writerCache.Load(wid); ok {
-			_, err = w.Close(ei.ctx)
+			_, err := w.Close(ei.ctx)
+			if err != nil {
+				if firstErr == nil {
+					firstErr = err
+				}
+			}
 		}
 		ei.writerCache.Delete(wid)
 	}
-	return err
+	return firstErr
 }
 
 // WriteRow Write one row into local writer buffer.