sessionctx: hide extended stats variable in SHOW VARIABLES temporarily (

#23345)
pingcap · Mar 18, 2021 · 389bc5f · 389bc5f
1 parent 1ab3b48
commit 389bc5f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/sessionctx/variable/tidb_vars.go b/sessionctx/variable/tidb_vars.go
@@ -713,6 +713,7 @@ var FeatureSwitchVariables = []string{
 	TiDBAnalyzeVersion,
 	TiDBPartitionPruneMode,
 	TiDBIntPrimaryKeyDefaultAsClustered,
+	TiDBEnableExtendedStats,
 }
 
 // FilterImplicitFeatureSwitch is used to filter result of show variables, these switches should be turn blind to users.

diff --git a/statistics/handle/handle_test.go b/statistics/handle/handle_test.go
@@ -2091,3 +2091,14 @@ func (s *testStatsSuite) TestExtendedStatsPartitionTable(c *C) {
 	err = tk.ExecToErr("alter table t2 add stats_extended s1 correlation(b,c)")
 	c.Assert(err.Error(), Equals, "Extended statistics on partitioned tables are not supported now")
 }
+
+func (s *testStatsSuite) TestHideExtendedStatsSwitch(c *C) {
+	// NOTICE: remove this test when this extended-stats reaches GA state.
+	defer cleanEnv(c, s.store, s.do)
+	tk := testkit.NewTestKit(c, s.store)
+	rs := tk.MustQuery("show variables").Rows()
+	for _, r := range rs {
+		c.Assert(strings.ToLower(r[0].(string)), Not(Equals), "tidb_enable_extended_stats")
+	}
+	tk.MustQuery("show variables like 'tidb_enable_extended_stats'").Check(testkit.Rows())
+}