Close lisener in server.Close

pingcap · Mar 6, 2023 · 1d62710 · 1d62710
1 parent 49eaee2
commit 1d62710
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/server/server.go b/server/server.go
@@ -559,6 +559,10 @@ var gracefulCloseConnectionsTimeout = 15 * time.Second
 // Close closes the server.
 func (s *Server) Close() {
 	s.startShutdown()
+	s.rwlock.Lock() // // prevent new connections
+	defer s.rwlock.Unlock()
+	s.inShutdownMode.Store(true)
+	s.closeListener()
 }
 
 func (s *Server) registerConn(conn *clientConn) bool {
@@ -874,8 +878,6 @@ func (s *Server) DrainClients(drainWait time.Duration, cancelWait time.Duration)
 	conns := make(map[uint64]*clientConn)
 
 	s.rwlock.Lock()
-	s.inShutdownMode.Store(true)
-	s.closeListener()
 	for k, v := range s.clients {
 		conns[k] = v
 	}