pump client: support change select pump's strategy #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IANTHEREAL
reviewed
Mar 20, 2019
| @@ -241,14 +242,19 @@ func (c *PumpsClient) getPumpStatus(pctx context.Context) (revision int64, err e | |||
|
|
|||
| // WriteBinlog writes binlog to a situable pump. Tips: will never return error for commit/rollback binlog. | |||
| func (c *PumpsClient) WriteBinlog(binlog *pb.Binlog) error { | |||
| c.RLock() | |||
| pumpNum := len(c.Pumps.AvaliablePumps) | |||
| selector := c.Selector | |||
There was a problem hiding this comment.
why putting it into a lock scope？
There was a problem hiding this comment.
Ok，I think you can put lock in selector, and provide an update function. it's better
There was a problem hiding this comment.
when change strategy will create a new selector. And selector is a member of pump client. so I think lock pump client seems better
|
Rest LGTM |
|
@july2993 Please take a careful look |
july2993
reviewed
Mar 20, 2019
july2993
reviewed
Mar 20, 2019
|
|
i know it it doesn't matter now, you should encapsulate such thinks in your |
|
In addition to the poor packaging, LGTM |
|
OK, I will refactor these code later. @GregoryIan |
WangXiangUSTC
added a commit
to WangXiangUSTC/tidb-tools
that referenced
this pull request
Mar 25, 2019
IANTHEREAL
pushed a commit
that referenced
this pull request
Mar 29, 2019
… strategy config (#223) * pump client: compatible with kafka version tidb-binlog && add unit test (#139) * pump client: write commit binlog will never return error (#148) * pkg watcher: move watcher from tidb-enterprise-tools (#146) * pump client: increase retry time, and refine some code (#158) * pump client: add initial log function (#165) * pump client: support change select pump's strategy (#221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support change select pump's strategy
proposal: pingcap/tidb#9201
What is changed and how it works?
create a new selector when change strategy
Check List
Tests
Code changes