Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS terraform: add zone label and reserved resources for nodes #871

Merged
merged 6 commits into from
Sep 6, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Sep 3, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

close #848
close #845

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Add zone label and reserved resources arguments to kubelet

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Sep 3, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Sep 4, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Sep 4, 2019

/run-e2e-in-kind

1 similar comment
@aylei
Copy link
Contributor Author

aylei commented Sep 5, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Sep 6, 2019

/run-e2e-in-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 12cea6a into pingcap:master Sep 6, 2019
@aylei
Copy link
Contributor Author

aylei commented Sep 6, 2019

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Sep 6, 2019

cherry pick to release-1.0 in PR #887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants