Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tidb-cloud-backup image tag (#846) #847

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 29, 2019

cherry-pick #846 to release-1.0


What problem does this PR solve?

Update image tag to pingcap/tidb-cloud-backup:20190828, in this version, rclone is introduced to upload and download the backup data pingcap/tidb-cloud-backup#4

What is changed and how does it work?

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Update the default backup image to pingcap/tidb-cloud-backup:20190828

@weekface
Copy link
Contributor

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor

weekface commented Sep 3, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 1f28b2f into pingcap:release-1.0 Sep 10, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* update release note for v1.1.6

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants