Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the instance label of drainer same with the TiDB cluster in favor of monitoring #812

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Aug 22, 2019

close #811

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Helm charts change

Does this PR introduce a user-facing change?:

No.

…r of monitoring

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei requested review from weekface and tennix August 22, 2019 09:32
@aylei
Copy link
Contributor Author

aylei commented Aug 22, 2019

@weekface @tennix PTAL

@aylei
Copy link
Contributor Author

aylei commented Aug 22, 2019

/run-e2e-test

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 6b6983e into pingcap:master Aug 23, 2019
aylei added a commit to aylei/tidb-operator that referenced this pull request Nov 18, 2019
aylei added a commit to aylei/tidb-operator that referenced this pull request Nov 18, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
…version (#812)

Signed-off-by: gongmengnan <gong.mengnan@ninjavan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resources created by tidb-drainer chart should have the same instance label with the source cluster
3 participants