Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Make incremental backup test work #764

Merged
merged 7 commits into from
Aug 13, 2019
Merged

e2e: Make incremental backup test work #764

merged 7 commits into from
Aug 13, 2019

Conversation

shuijing198799
Copy link
Contributor

@shuijing198799 shuijing198799 commented Aug 12, 2019 •
edited
Loading

What problem does this PR solve?

Fix bug of incremental backup test

What is changed and how does it work?

add json tag to pump statusmap, adjust misunderstanding of drainer field synced, fix typo, and fix http protocol error

Check List

Tests

  • E2E test

Code changes

  • Has Go code change

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799
Copy link
Contributor Author

/run-e2e-in-kind

@shuijing198799 shuijing198799 changed the title [DNM]e2e:Add json tag to pump statusmap [DNM]e2e:Make incremental backup test work Aug 13, 2019
@shuijing198799 shuijing198799 marked this pull request as ready for review August 13, 2019 05:43
@shuijing198799 shuijing198799 mentioned this pull request Aug 13, 2019
Closed
weekface
weekface approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface changed the title [DNM]e2e:Make incremental backup test work e2e: Make incremental backup test work Aug 13, 2019
@shuijing198799 shuijing198799 merged commit a3c9889 into pingcap:master Aug 13, 2019
@shuijing198799 shuijing198799 deleted the yinliang/e2e-pump-jsontag branch August 13, 2019 06:40
@sre-bot sre-bot mentioned this pull request Aug 13, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Aug 13, 2019

cherry pick to release-1.0 in PR #765

shuijing198799 pushed a commit that referenced this pull request Aug 13, 2019
@sre-bot @shuijing198799
e2e: Make incremental backup test work (#764) (#765)
6e10a21 
* e2e:Add json tag to pump statusmap

* e2e: add protocol name in get drainer and pump

* fix typo

* add some log

* delete log and adjust misunderstand of drainer field Synced
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang
zh: add v1.1-rc.1 release notes (#764)
b81458e 
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.0 type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuijing198799 @sre-bot @weekface @xiaojingchen