Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: inject a failure by pod annotation (#716) #739

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 7, 2019

cherry-pick #716 to release-1.0


This can be useful for testing scheduling failures.
You can for example add it to monitor-deployment
along with changing the scheduler to the custom scheduler.

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    I tested as mentioned in the PR. I observed that no other pods had failed scheduling, including after deploying a second TiDB cluster.

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

gregwebs and others added 3 commits August 8, 2019 05:00
This can be useful for testing scheduling failures.
You can for example add it to monitor-deployment
along with changing the scheduler to the custom scheduler.
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit f7fed07 into pingcap:release-1.0 Aug 8, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* update dashboard.md

* update doc

* address comments

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants