Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: update wording and fix format for v1.0.0 #709

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 30, 2019

What problem does this PR solve?

This PR updates v1.0.0 changelog description, and fixes typos and format.

What is changed and how does it work?

Only changelog

Check List

N/A

Does this PR introduce a user-facing change?:

N/A

@lilin90 lilin90 requested review from weekface and tennix July 30, 2019 14:53
weekface
weekface previously approved these changes Jul 30, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
@lilin90 lilin90 dismissed stale reviews from weekface via a9cfd5c July 30, 2019 15:40
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 5baa7c9 into pingcap:master Jul 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

cherry pick to release-1.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

cherry pick to release-1.0 in PR #710

yahonda pushed a commit that referenced this pull request Dec 27, 2021
* hetergeneous

* hetergeneous

* hetergeneous

* hetergeneous

* hetergeneous

* hetergeneous

* hetergeneous

* hetergeneous

* Update zh/TOC.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Apply suggestions from code review

optimize

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/deploy-heterogeneous-tidb-cluster.md

Co-authored-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

fix

Co-authored-by: Ran <huangran@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants