Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configmap rollout by default and quote configmap digest suffix #678

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Enable configmap rollout by default and quote configmap digest suffix #678

merged 2 commits into from
Jul 22, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jul 22, 2019

What problem does this PR solve?

Enable configmap rollout by default and quote configmap digest suffix

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change
  • Has Go code change

Side effects

  • The tidb cluster will perform a rolling update when user upgrade chart from the prior versions.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Configmap rollout is now enabled by default.

aylei added 2 commits July 22, 2019 16:40
@aylei
Fix helm rendering error when configmap SHA only consists of digits
7b25638 
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Enable configmap rollout by default
93eb024 
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Jul 22, 2019

/run-e2e-tests

tennix
tennix approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface added this to the v1.0.0 milestone Jul 22, 2019
@weekface weekface merged commit 20e8cf2 into pingcap:master Jul 22, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
@aylei @weekface
Enable configmap rollout by default and quote configmap digest suffix (…
0bce383 
…#678)

* Fix helm rendering error when configmap SHA only consists of digits

Signed-off-by: Aylei <rayingecho@gmail.com>

* Enable configmap rollout by default

Signed-off-by: Aylei <rayingecho@gmail.com>
(cherry picked from commit 20e8cf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aylei @weekface @tennix