Local SSD on GKE #577
Merged
Local SSD on GKE #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
force-pushed
the
local-ssd-provision
branch
from
3515c90
to
ece488a
Compare
jlerche
previously approved these changes
Jun 12, 2019
gregwebs
force-pushed
the
local-ssd-provision
branch
from
a2d8ad3
to
16fde87
Compare
* Add GKE ssd provisioning scripts that fix performance and capacity issues * Document in the operation guide, and link documentation * Don't use by default for PD. Benchmarking has now shown a significant improvement for PD.
gregwebs
force-pushed
the
local-ssd-provision
branch
from
16fde87
to
44afaab
Compare
|
This is working now. One thing that showed up in my testing is that when deleting a tidb cluster deployment (helm delete + namespace delete) and then deploying again, tikv will be stuck in pending. I will check to see if this is already the current behavior and if changing the namespace helps. |
|
I tested the previous terraform, and destroying and then deploying again also does not work, so there are no regressions here. |
|
/run-e2e-tests |
cofyc
approved these changes
Jun 14, 2019
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
jlerche
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking has now shown a significant improvement.
Testing
The provisioner script is well tested. I haven't yet tested this contribution to tidb-operator. We need to test