release v1.0.0-beta.3 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
…idb-operator into release-v1.0.0-beta.3
aylei
reviewed
Jun 6, 2019
| @@ -1921,7 +1921,7 @@ func (oa *operatorActions) CheckScheduledBackup(info *TidbClusterConfig) error { | |||
|
|
|||
| succededJobCount := 0 | |||
| for _, j := range backupJobs { | |||
| if j.Status.Failed > 0 { | |||
| if j.Status.Failed > 3 { | |||
There was a problem hiding this comment.
Yes, the pod may fail one or two times.
weekface
commented
Jun 6, 2019
| @@ -96,7 +96,7 @@ func NewOperatorActions(cli versioned.Interface, | |||
| const ( | |||
| DefaultPollTimeout time.Duration = 10 * time.Minute | |||
| DefaultPollInterval time.Duration = 1 * time.Minute | |||
| BackupAndRestorePollTimeOut time.Duration = 30 * time.Minute | |||
| BackupAndRestorePollTimeOut time.Duration = 60 * time.Minute | |||
There was a problem hiding this comment.
We need a longer restore period.
xiaojingchen
previously approved these changes
Jun 6, 2019
|
/run-e2e-test |
tennix
reviewed
Jun 6, 2019
|
/run-e2e-test |
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
xiaojingchen
approved these changes
Jun 6, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add aliases in configure-a-tidb-cluster.md * fix wrong aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: