-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aliyun tf output rendering and refine documents #511
Conversation
… refine documents Signed-off-by: Aylei <rayingecho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tennix Thanks for your review, I've fix a merge conflict just now, could you please take a look again? |
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
/run-e2e-tests |
/run-e2e-tests |
* Add telemetry notes * 理解和改善产品 -> 改善产品 * Add EN doc * Fix some links * Address comments * Sync changes from CN doc * Sync changes from docs Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
Fix the output render error when kubernetes is not successfully created in aliyun.
What is changed and how it works?
TF scripts changed.
Check List
Tests
@AstroProfundis @tennix @IzabelWang PTAL