Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restore script bug #510

Merged
merged 4 commits into from
May 27, 2019
Merged

Conversation

xiaojingchen
Copy link
Contributor

What problem does this PR solve?

this pr fixes:#509

What is changed and how it works?

Check List

Tests

  • E2E test [done]
  • Stability test [WIP]
  • Manual test [done]

Code changes

  • Has Helm charts change

Does this PR introduce a user-facing change?:

None

@xiaojingchen xiaojingchen requested review from tennix and onlymellb May 23, 2019 08:11
@aylei aylei added the type/bug Something isn't working label May 23, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-test

Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen
Copy link
Contributor Author

/run-e2e-test

@xiaojingchen
Copy link
Contributor Author

/run-e2e-test

@weekface
Copy link
Contributor

/run-e2e-test

@weekface weekface merged commit 5f28fba into pingcap:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the restore script failed when the db user has not password
4 participants