Add case for kube proxy #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2019 21:20
|
LGTM |
weekface
reviewed
May 23, 2019
tests/failover.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| glog.V(4).Infof("all clusters are available.") | ||
| return nil |
| if err != nil { | ||
| glog.Infof("can't find controllerManager in node:%s", faultNode) | ||
| slack.NotifyAndPanic(fmt.Errorf("can't find kube-controller-manager in k8s cluster")) |
There was a problem hiding this comment.
@onlymellb the controller pod may be not in the master, this case is normal
| if err != nil { | ||
| glog.Infof("can't find scheduler in node:%s", faultNode) | ||
| slack.NotifyAndPanic(fmt.Errorf("can't find kube-scheduler in k8s cluster")) |
There was a problem hiding this comment.
scheduler pod can run in work node
There was a problem hiding this comment.
If the returned err is not nil, it means that search this component in kube-system namespace has failed. If the master node does not have this component, the returned err is nil. Therefore, it is necessary to send an alarm and panic when the returned error is not nil.
|
@onlymellb please address @xiaojingchen comments |
…perator into add-case-for-kube-proxy
|
/run-e2e-tests |
|
@onlymellb |
This was referenced Jun 5, 2019
Closed
|
fixed by: #556 |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add helm offline doc * update format * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: