-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stability cases added: pd replicas 1 and stop tidb-operator #496
Conversation
/run-e2e-tests |
@@ -148,6 +149,23 @@ func main() { | |||
TiDBTokenLimit: 1000, | |||
PDLogLevel: "info", | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the one pd test in e2e test and stability test is different ? this test may only test deploy TiDB cluster, so I think the e2e test did a lot of extra work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order to cover this issue: #350
LGTM |
/run-e2e-tests |
…ator into pd-replicas-1
/run-e2e-tests |
- /usr/local/bin/stability-test | ||
- --config=/etc/tidb-operator-stability/config.yaml | ||
- --operator-image=pingcap/tidb-operator:v1.0.0-beta.2 | ||
- --operator-tag=v1.0.0-beta.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can define image-repo
and image-tag
to avoid passing the same version twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the operator-tag
is used by git clone to check out the source code.
For example, the image maybe pingcap/tidb-operator:latest
and the operator-tag
is master
.
tests/failover.go
Outdated
return err | ||
} | ||
err = oa.CheckTidbClustersAvailable(clusters) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return err
directly.
/run-e2e-tests |
/run-e2e-tests |
@tennix @shuijing198799 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: