Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/aws: update AWS deploy docs after testing #491

Merged
merged 7 commits into from
May 15, 2019

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented May 14, 2019

What problem does this PR solve?

Testing current documentation of deploying TiDB Operator on AWS with Terraform and keep it up to date.

What is changed and how it works?

Tested all instructions in the AWS installation documentation on a VM with latest ArchLinux, updated them to fit testing results and added some detailed notes.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has documents change

Side effects

  • N/A

Related changes

  • N/A

Does this PR introduce a user-facing change?:

NONE

@tennix tennix requested a review from jlerche May 14, 2019 13:05
jlerche
jlerche previously approved these changes May 14, 2019
Copy link
Contributor

@jlerche jlerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deploy/aliyun/README.md Outdated Show resolved Hide resolved
deploy/aws/README.md Outdated Show resolved Hide resolved
deploy/aws/README.md Outdated Show resolved Hide resolved
deploy/aws/README.md Outdated Show resolved Hide resolved
deploy/aws/README.md Outdated Show resolved Hide resolved
docs/aws-eks-tutorial.md Outdated Show resolved Hide resolved
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@AstroProfundis AstroProfundis dismissed stale reviews from jlerche via 02b652f May 15, 2019 08:37
docs/aws-eks-tutorial.md Outdated Show resolved Hide resolved
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AstroProfundis AstroProfundis merged commit 2f8ccdd into pingcap:master May 15, 2019
@AstroProfundis AstroProfundis deleted the update-docs-aws branch May 15, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants