-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DinD image to make it possible to configure HTTP proxies #485
Conversation
This is used to whitelist all internal k8s domains, local registry (e.g. http://127.0.0.1:5000) and other IP addresses. |
Do we need to add instructions to the doc? |
@AstroProfundis sure, I'd like to add this as an alternative option to |
@onlymellb I've updated DinD image and tested it on Linux successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b003545
to
ed72b54
Compare
@weekface @onlymellb |
/run-e2e-tests |
This pr needs to add a release note? @cofyc |
What problem does this PR solve?
fixes #461
What is changed and how it works?
Check List
Tests
Manual test (add detailed scripts or steps below)
configure http proxies in docker config.json
propagate http proxies to dind containers
Does this PR introduce a user-facing change?: