Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stable scheduling for TiDB #477

Merged
merged 8 commits into from
May 17, 2019
Merged

Support stable scheduling for TiDB #477

merged 8 commits into from
May 17, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented May 9, 2019

What problem does this PR solve?

fixes #332

What is changed and how it works?

See design proposal in #466

Check List

Tests

Unit test (done)
E2E test (done)
Manual test (done)

Code changes

Has Go code change

Side effects

Controlled by a feature gate, no side effects if not enabled.

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?:

Support stable scheduling for pods of TiDB members in tidb-scheduler.

@cofyc cofyc changed the title WIP: Support stable scheduling for TiDB Support stable scheduling for TiDB May 10, 2019
@cofyc cofyc force-pushed the fix332 branch 2 times, most recently from add629c to aa0c632 Compare May 13, 2019 06:33
@cofyc
Copy link
Contributor Author

cofyc commented May 13, 2019

/run-e2e-tests

weekface
weekface previously approved these changes May 14, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weekface
Copy link
Contributor

/run-e2e-tests

@weekface
Copy link
Contributor

please add a release note to #477 (comment)

@cofyc
Copy link
Contributor Author

cofyc commented May 15, 2019

done

@weekface
Copy link
Contributor

@tennix @xiaojingchen PTAL

xiaojingchen
xiaojingchen previously approved these changes May 16, 2019
@cofyc cofyc dismissed stale reviews from xiaojingchen and weekface via 2c90fe3 May 16, 2019 06:34
@cofyc
Copy link
Contributor Author

cofyc commented May 16, 2019

/run-e2e-tests

@cofyc
Copy link
Contributor Author

cofyc commented May 16, 2019

@weekface @xiaojingchen I've rebased on the latest master, PTAL again.

@cofyc
Copy link
Contributor Author

cofyc commented May 16, 2019

/run-e2e-tests
Merge master and run e2e again.

@cofyc
Copy link
Contributor Author

cofyc commented May 17, 2019

/run-e2e-tests
Merge master and run e2e again.

@cofyc
Copy link
Contributor Author

cofyc commented May 17, 2019

Follow-up issue: #498

@cofyc cofyc merged commit e5efea7 into pingcap:master May 17, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* en: remove a warning in monitor

* en: update timezone setting in faq

* Update link

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Allow tidb pod to be scheduled on the previous node
3 participants