Add tkctl user manual #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
weekface
reviewed
May 8, 2019
| ``` | ||
| $ tkctl get tikv | ||
| NAME READY STATUS MEMORY CPU RESTARTS AGE NODE | ||
| demo-cluster-tikv-0 2/2 Running 2098Mi/4196Mi 0 3m19s 172.16.4.155 |
There was a problem hiding this comment.
the CPU column is empty now.
There was a problem hiding this comment.
In this example the CPU request and limit is not set.
Of course a <none>/<none> is more clear for user, I will open a new issue for this.
There was a problem hiding this comment.
[root@172.16.4.149 ~]# tkctl get tikv
NAME READY STATUS MEMORY CPU RESTARTS AGE NODE
cluster-restore-tikv-0 2/2 Running 2098Mi/8292Mi 0 5m22s 172.16.4.150
cluster-restore-tikv-1 2/2 Running 2098Mi/8292Mi 0 5m22s 172.16.4.154
cluster-restore-tikv-2 2/2 Running 2098Mi/8292Mi 0 5m22s 172.16.4.149
I try it on many clusters, but they are all empty.
There was a problem hiding this comment.
I will amend the manual along with the fix #465
onlymellb
reviewed
May 8, 2019
onlymellb
reviewed
May 8, 2019
onlymellb
reviewed
May 8, 2019
cofyc
reviewed
May 8, 2019
onlymellb
reviewed
May 8, 2019
weekface
approved these changes
May 8, 2019
tennix
approved these changes
May 8, 2019
shuijing198799
pushed a commit
to shuijing198799/tidb-operator
that referenced
this pull request
May 9, 2019
* Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link
shuijing198799
added a commit
to shuijing198799/tidb-operator
that referenced
this pull request
May 9, 2019
Add version command for tkctl (pingcap#456) * Add version command for tkctl Signed-off-by: Aylei <rayingecho@gmail.com> Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link add tools code and modify code
shuijing198799
added a commit
to shuijing198799/tidb-operator
that referenced
this pull request
May 9, 2019
* use shareinformer without copy * fix bug use shareinformer without copy in kv pd and svc add webhook Add version command for tkctl (pingcap#456) * Add version command for tkctl Signed-off-by: Aylei <rayingecho@gmail.com> Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link add tools code and modify code use shareinformer without copy fix bug use shareinformer without copy in kv pd and svc add webhook Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* en: update access-dashboard * Update en/access-dashboard.md * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add user manual for
tkctlPreview: https://github.com/aylei/tidb-operator/blob/issue-305-doc/docs/cli-manual.md
@tennix @onlymellb @gregwebs @weekface @cofyc PTAL
Todo
Support tkctl as kubectl plugin(postpone)