Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix label selector #437

Merged
merged 1 commit into from
May 5, 2019
Merged

Docs: fix label selector #437

merged 1 commit into from
May 5, 2019

Conversation

LinuxGit
Copy link
Contributor

What problem does this PR solve?

refer: https://github.com/pingcap/tidb-operator/blob/master/charts/tidb-cluster/templates/tidb-cluster.yaml#L8

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has documents change

tennix
tennix approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxGit LinuxGit merged commit 545e7a7 into pingcap:master May 5, 2019
@LinuxGit LinuxGit deleted the Louis/fix-docs branch May 5, 2019 02:47
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@cofyc @DanielZhangQD
en: describe how to use alternative images in get started tutorial (#437
a789dd5 
)

* en: describe how to use alternative images in get started tutorial

* use registry.cn-beijing.aliyuncs.com/tidb

* avoid using too specific wording

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@tennix tennix tennix approved these changes

@xiaojingchen xiaojingchen Awaiting requested review from xiaojingchen

Assignees
No one assigned
Labels
area/doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LinuxGit @weekface @tennix @gregwebs