Support running stability test out of cluster #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
cofyc
reviewed
Apr 16, 2019
onlymellb
reviewed
Apr 16, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
|
@cofyc @onlymellb @xiaojingchen PTAL again |
aylei
requested review from
cofyc,
xiaojingchen and
onlymellb
and removed request for
cofyc
Signed-off-by: Aylei <rayingecho@gmail.com>
|
I've updated the docs too |
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
onlymellb
reviewed
Apr 16, 2019
cofyc
reviewed
Apr 16, 2019
| func checkoutTag(tagName string) error { | ||
| cmd := fmt.Sprintf(`cd /tidb-operator && | ||
| func (oa *operatorActions) checkoutTag(tagName string) error { | ||
| cmd := fmt.Sprintf(`cd %s && | ||
| git stash -u && | ||
| git checkout %s && | ||
| mkdir -p /charts/%s && | ||
| cp -rf charts/tidb-operator /charts/%s/tidb-operator && | ||
| cp -rf charts/tidb-cluster /charts/%s/tidb-cluster && | ||
| cp -rf charts/tidb-backup /charts/%s/tidb-backup`, |
There was a problem hiding this comment.
(do not block this PR) Is it possible to copy them to temporary directories which are always writable in the future? I guess the path does not matter here. Then we can simplify the workflow (do not need to prepare /charts).
There was a problem hiding this comment.
Agreed for future work, I've tried but found that /charts is hard coded in many places😅
…y provided Signed-off-by: Aylei <rayingecho@gmail.com>
|
@cofyc @xiaojingchen @weekface @onlymellb I've updated the doc, PTAL again. |
weekface
approved these changes
Apr 16, 2019
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy & witness flow can be tedious when developing stability-test, this PR introduce the ability to run stability-test out of the cluster(your local machine, usually) while still operating the remote cluster.
How-to: generally we have three problems to solve:
TL;DR:
Explained
kubeconfigcommand line option provided, use itKUBECONFIGenv variable set, use itInClusterConfig()InClusterConfig()provided, try loading kubeconfig file from default location (~/.kube/config)so typically you will get right client configs if you have proper
~/.kube/configin your local environment.--git-repo-dir=xxxx, but helm dir must be created manually.telepresencehelps with that, it creates a proxy pod in the cluster and open a vpn connection to kubernetes cluster via this pod. Just run (full documentations):$ brew cask install osxfuse $ brew install datawire/blackbird/telepresence $ telepresence --new-deployment ${POD_NAME}PS: If you cannot resolve cluster dns names after set up, try clear DNS cache.
PSS: Typically you can't use telepresence VPN mode with other VPNs (of course SSR is ok).
Signed-off-by: Aylei rayingecho@gmail.com