Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DinD k8s version to v1.12 #352

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Conversation

weekface
Copy link
Contributor

@weekface weekface requested review from tennix and onlymellb March 27, 2019 09:54
@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregwebs
Copy link
Contributor

How about 1.13?

@weekface
Copy link
Contributor Author

We currently only do a lot of stability testing on 1.12, other versions have not yet

@weekface
Copy link
Contributor Author

weekface commented Apr 1, 2019

/run-e2e-tests

@weekface
Copy link
Contributor Author

weekface commented Apr 1, 2019

@tennix PTAL

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 91fe703 into pingcap:master Apr 1, 2019
@weekface weekface deleted the fix-dind-doc branch April 1, 2019 06:22
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* Fix _index.md

* fix links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants