Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix goroutine leak when tls enabled (#3081) #3083

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3081 to release-1.1


What problem does this PR solve?

Fix #3079

What is changed and how does it work?

Disable keepalive for TLS connections, more detail refer to elastic/cloud-on-k8s#854 (comment)

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Fix goroutine leak when TLS enabled

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@b22f180). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.1    #3083   +/-   ##
==============================================
  Coverage               ?   44.52%           
==============================================
  Files                  ?      148           
  Lines                  ?    15804           
  Branches               ?        0           
==============================================
  Hits                   ?     7037           
  Misses                 ?     8203           
  Partials               ?      564           
Flag Coverage Δ
#unittest 44.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-srebot ti-srebot merged commit e4d8e03 into pingcap:release-1.1 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants