set TZ environment for webhook and advanced statefulset #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operator chart should honor .Values.timezone backup-manager job should use the same timezone of tidb-controller-manager
cofyc
requested review from
DanielZhangQD,
weekface and
lichunzhu
and removed request for
DanielZhangQD
cofyc
commented
Jul 29, 2020
| @@ -151,7 +151,7 @@ apiserver: | |||
| # kubectl apply -f manifests/advanced-statefulset-crd.v1.yaml # k8s version >= 1.16.0 | |||
| advancedStatefulset: | |||
| create: false | |||
| image: pingcap/advanced-statefulset:v0.3.3 | |||
| image: pingcap/advanced-statefulset:v0.4.0 | |||
There was a problem hiding this comment.
This new image contains tzdata, so that we can use TZ environment to configure the local time zone.
Codecov Report
@@ Coverage Diff @@
## master #3034 +/- ##
==========================================
+ Coverage 41.92% 42.15% +0.23%
==========================================
Files 156 156
Lines 16777 16709 -68
==========================================
+ Hits 7033 7043 +10
+ Misses 9172 9094 -78
Partials 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-srebot
approved these changes
Jul 30, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 30, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #3041 |
ti-srebot
added a commit
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #2944
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: