Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tools in backup manager to v4.0.3 #3019

Merged
merged 1 commit into from
Jul 27, 2020
Merged

update tools in backup manager to v4.0.3 #3019

merged 1 commit into from
Jul 27, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

resolve #2995

What is changed and how does it work?

update version

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
    • Manual version check in pod

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

update tools in backup manager to v4.0.3

@lichunzhu lichunzhu added status/PTAL PR needs to be reviewed needs-cherry-pick-1.1 labels Jul 25, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #3019 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   41.93%   41.93%           
=======================================
  Files         156      156           
  Lines       16773    16773           
=======================================
  Hits         7033     7033           
  Misses       9172     9172           
  Partials      568      568
Flag Coverage Δ
#unittest 41.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lichunzhu
Copy link
Contributor Author

/test pull-e2e-kind

1 similar comment
@lichunzhu
Copy link
Contributor Author

/test pull-e2e-kind

DanielZhangQD
DanielZhangQD approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 43e4d37 into pingcap:master Jul 27, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jul 27, 2020
@lichunzhu @ti-srebot
cherry pick pingcap#3019 to release-1.1
81ea2c5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3020

ti-srebot added a commit that referenced this pull request Jul 27, 2020
@ti-srebot @lichunzhu @DanielZhangQD
update tools in backup manager to v4.0.3 (#3019) (#3020)
a150cd9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@lichunzhu lichunzhu deleted the updateToolToV403 branch September 2, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/LGT2 status/PTAL PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the tools in the backup-manager to v4.0.3
5 participants
@lichunzhu @codecov-commenter @ti-srebot @cofyc @DanielZhangQD