Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TiKV auto-scaling (#2862) #2871

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Refactor TiKV auto-scaling (#2862) #2871

merged 1 commit into from
Jul 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2862 to release-1.1

What problem does this PR solve?

  1. refactor the tikv auto-scaling controller to be ready for the storage auto-scaling
  2. deprecated the de-nosie strategy due to it make auto-scaling in operator too complicated, and we will finally let pd to handle the auto-scaling strategy layer, and auto-scaler controller become the execution layer.

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Remove  `readyToScaleThresholdSeconds` in `TidbClusterAutoScaler`, Operator won't support de-noise in `TidbClusterAutoScaler`

@Yisaer @ti-srebot
cherry pick pingcap#2862 to release-1.1
3bf11be 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 6, 2020
Merged
@ti-srebot ti-srebot added this to the v1.1.3 milestone Jul 6, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Jul 6, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Jul 6, 2020

/merge

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@Yisaer
Copy link
Contributor

Yisaer commented Jul 6, 2020

/run-e2e-in-kind

@cofyc cofyc merged commit fadcee6 into pingcap:release-1.1 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

@weekface weekface Awaiting requested review from weekface

@zjj2wry zjj2wry Awaiting requested review from zjj2wry

Assignees

@Yisaer Yisaer

Labels
area/auto-scaling related to auto-scaling CanMerge
Projects
None yet
Milestone
v1.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @Yisaer @cofyc