fix join script #285
Merged
fix join script #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
onlymellb
reviewed
Feb 26, 2019
| # The --join args must be: | ||
| # --join=http://demo-pd-0.demo-pd-peer.demo.svc:2380,http://demo-pd-1.demo-pd-peer.demo.svc:2380 | ||
| join=`cat /var/lib/pd/join | tr "," "\n" | awk -F'=' '{print $2}' | tr "\n" ","` | ||
| join=${join%?} |
There was a problem hiding this comment.
I think it is better to use join=${join%,} instead of join=${join%?}, the former will only delete the last string that is a comma, the latter always deletes the last string, so the former is safer.
|
/run-e2e-tests |
shuijing198799
pushed a commit
to shuijing198799/tidb-operator
that referenced
this pull request
Mar 15, 2019
* fix join script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the data directory has a
joinfile, startpd-serverwith--join =args(it can't be empty), which is the contents of thejoinfile, otherwise request the discovery service.@tennix @xiaojingchen @onlymellb PTAL