Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterIDLabelKey label to TidbCluster #279

Merged
merged 5 commits into from
Feb 21, 2019
Merged

Add ClusterIDLabelKey label to TidbCluster #279

merged 5 commits into from
Feb 21, 2019

Conversation

xiaojingchen
Copy link
Contributor

@xiaojingchen xiaojingchen commented Feb 19, 2019 •
edited
Loading

this PR add ClusterIDLabelKey label to tidbCluster and add ClusterID field in TidbCluster.Status
@weekface @tennix PTAL

@xiaojingchen xiaojingchen changed the title Add ClusterIDLabelKey label to TidbCluster [WIP]Add ClusterIDLabelKey label to TidbCluster Feb 19, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen xiaojingchen changed the title [WIP]Add ClusterIDLabelKey label to TidbCluster Add ClusterIDLabelKey label to TidbCluster Feb 19, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

tennix
tennix approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

/run-e2e-tests

@tennix tennix merged commit a2a37ab into pingcap:master Feb 21, 2019
@xiaojingchen xiaojingchen deleted the add-label branch February 21, 2019 05:46
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang
en: simplify kind tutorial (#279)
7456499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaojingchen @weekface @tennix