Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert rules lost after rolling upgrade (#2715) #2728

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix alert rules lost after rolling upgrade (#2715) #2728

merged 1 commit into from
Jun 16, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2715 to release-1.0

What problem does this PR solve?

Part of: #2710

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Fix alert rules lost after rolling upgrade

@weekface @ti-srebot
cherry pick pingcap#2715 to release-1.0
3489999 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
@ti-srebot ti-srebot added this to the v1.0.7 milestone Jun 16, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Jun 16, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@Yisaer
Copy link
Contributor

Yisaer commented Jun 16, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@weekface
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@cofyc cofyc merged commit 7d826ec into pingcap:release-1.0 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

@qiffang qiffang Awaiting requested review from qiffang

Assignees

@weekface weekface

Labels
CanMerge
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @Yisaer @weekface @cofyc