Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP:Support Service LoadBalancerSourceRanges (#2610) #2640

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 8, 2020

cherry-pick #2610 to release-1.1


What problem does this PR solve?

UCP: #2586
Close: #2586
Resolve: #2564

What is changed and how does it work?

  1. Add loadBalancerSourceRanges to service spec.
  2. Expose it on the TiDB Service and Monitor Service.
  3. Add some unit tests for setting LoadBalancerSourceRanges on the TiDB Service and Monitor Service.

Check List

Tests

  • Unit test
  • E2E test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support LoadBalancerSourceRanges in the ServiceSpec for the TidbCluster and TidbMonitor.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@Yisaer
Copy link
Contributor

Yisaer commented Jun 8, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

Your auto merge job has been accepted, waiting for:

  • 2632

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

/run-all-tests

@Yisaer
Copy link
Contributor

Yisaer commented Jun 8, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

@sre-bot merge failed.

@Yisaer
Copy link
Contributor

Yisaer commented Jun 8, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

Your auto merge job has been accepted, waiting for:

  • 2649

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 8, 2020

/run-all-tests

@Yisaer Yisaer merged commit b72e346 into pingcap:release-1.1 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants