new algorithm for scheduler HA predicate #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
/run-e2e-tests |
xiaojingchen
reviewed
Jan 7, 2019
pkg/scheduler/predicates/ha_test.go
Outdated
| }, | ||
| }, | ||
| { | ||
| name: "one pod, podName is wrong", | ||
| ordinal: 0, | ||
| name: "one node, return zero node", |
There was a problem hiding this comment.
Suggested change
| name: "one node, return zero node", | |
| name: "zero node, return zero node", |
onlymellb
reviewed
Jan 8, 2019
Co-Authored-By: weekface <weekface@gmail.com>
onlymellb
reviewed
Jan 8, 2019
| if !minInitialized { | ||
| minInitialized = true | ||
| min = count | ||
| min := -1 |
There was a problem hiding this comment.
Is it better to initialize the min variable to a large enough value?
There was a problem hiding this comment.
Large enough, how big is it?
There was a problem hiding this comment.
The default number of pods that can be run on a kubelet is 110, so I think it's okay to be larger than this number, what do you think?
There was a problem hiding this comment.
This number may be modified by the user. -1 is good enough i think.
onlymellb
reviewed
Jan 8, 2019
…perator into new-scheduler-ha
|
/run-e2e-tests |
tennix
reviewed
Jan 8, 2019
pkg/scheduler/predicates/ha_test.go
Outdated
| @@ -39,229 +40,327 @@ func TestMapNil(t *testing.T) { | |||
|
|
|||
| g.Expect(m["c"] == nil).To(Equal(true)) | |||
| g.Expect(m["a"] == nil).To(Equal(false)) | |||
|
|
|||
| var i *int | |||
| g.Expect(i).To(BeNil()) | |||
pkg/scheduler/predicates/ha_test.go
Outdated
| g.Expect(i).To(BeNil()) | ||
| } | ||
|
|
||
| func TestSortEmptyArr(t *testing.T) { |
xiaojingchen
approved these changes
Jan 9, 2019
|
/run-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #235
@tennix @onlymellb @xiaojingchen PTAL