fix scheduler policy issue #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
tennix
reviewed
Dec 27, 2018
charts/tidb-operator/values.yaml
Outdated
| # modify the hyperkube verison to your kubernetes version | ||
| kubeSchedulerImage: gcr.io/google-containers/hyperkube:v1.10.12 | ||
| # this hyperkube verison must be the same as your kubernetes cluster version | ||
| kubeSchedulerImage: gcr.io/google-containers/hyperkube:v1.12.1 |
There was a problem hiding this comment.
Comment this out and make this field required, so users have to fill this out when installing tidb-operator.
weekface
commented
Dec 27, 2018
|
/run-e2e-tests |
xiaojingchen
approved these changes
Dec 27, 2018
gregwebs
approved these changes
Dec 27, 2018
|
/run-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had tested in kubernetes v1.10, v1.11 and v1.12
@tennix @onlymellb @xiaojingchen PTAL